Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1490113003: X87: [turbofan] Implemented the optional Float32RoundDown operator. (Closed)

Created:
5 years ago by zhengxing.li
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [turbofan] Implemented the optional Float32RoundDown operator. port 74434403f6d3e8a367992ce672bf112dd3955554 (r32261) original commit message: I implemented the optional Float32RoundDown operator on x64, ia32, arm, and arm64. For arm I also had to adjust the simulator. BUG= Committed: https://crrev.com/ed679e528067f04023c5e861a769715a8fc51e47 Cr-Commit-Position: refs/heads/master@{#32492}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
5 years ago (2015-12-02 07:12:45 UTC) #2
Weiliang
lgtm
5 years ago (2015-12-02 07:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490113003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490113003/1
5 years ago (2015-12-02 07:41:54 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-02 08:02:41 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-02 08:03:26 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ed679e528067f04023c5e861a769715a8fc51e47
Cr-Commit-Position: refs/heads/master@{#32492}

Powered by Google App Engine
This is Rietveld 408576698