Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 1490073005: Add missing comma in compat.gyp (Closed)

Created:
5 years ago by scottmg
Modified:
5 years ago
Reviewers:
Mark Mentovai
CC:
crashpad-dev_chromium.org, brucedawson
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Add missing comma in compat.gyp Causes a warning in the gyp-msvs generator. R=mark@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/fabcd790578e904b3bff34fdf6e91edb4906a4e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M compat/compat.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
scottmg
5 years ago (2015-12-02 23:21:45 UTC) #3
Mark Mentovai
LGTM, very much
5 years ago (2015-12-02 23:26:45 UTC) #4
scottmg
5 years ago (2015-12-02 23:31:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fabcd790578e904b3bff34fdf6e91edb4906a4e2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698