Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayer.h

Issue 1490063002: Implement Paint Containment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix merge Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintLayer.h
diff --git a/third_party/WebKit/Source/core/paint/PaintLayer.h b/third_party/WebKit/Source/core/paint/PaintLayer.h
index e02293d325157fd771efb93ba989a77585f50749..17a1633ab73d41c13f9ac9ff2a55822d95ba6449 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayer.h
+++ b/third_party/WebKit/Source/core/paint/PaintLayer.h
@@ -261,14 +261,13 @@ public:
bool hasVisibleNonLayerContent() const { return m_hasVisibleNonLayerContent; }
bool hasNonCompositedChild() const { ASSERT(isAllowedToQueryCompositingState()); return m_hasNonCompositedChild; }
- // Gets the ancestor layer that serves as the containing block of this layer. It is assumed
- // that this layer is established by an out-of-flow positioned layout object (i.e. either
- // absolutely or fixed positioned).
+ // Gets the ancestor layer that serves as the containing block of this layer. This is either
+ // another out of flow positioned layer, or one that contains paint.
// If |ancestor| is specified, |*skippedAncestor| will be set to true if |ancestor| is found in
// the ancestry chain between this layer and the containing block layer; if not found, it will
// be set to false. Either both |ancestor| and |skippedAncestor| should be nullptr, or none of
// them should.
- PaintLayer* enclosingPositionedAncestor(const PaintLayer* ancestor = nullptr, bool* skippedAncestor = nullptr) const;
+ PaintLayer* containingLayerForOutOfFlowPositioned(const PaintLayer* ancestor = nullptr, bool* skippedAncestor = nullptr) const;
bool isPaintInvalidationContainer() const;
@@ -459,15 +458,6 @@ public:
PaintLayerClipper& clipper() { return m_clipper; }
const PaintLayerClipper& clipper() const { return m_clipper; }
- inline bool isPositionedContainer() const
- {
- // FIXME: This is not in sync with containingBlock.
- // LayoutObject::canContainFixedPositionObjects() should probably be used
- // instead.
- LayoutBoxModelObject* layerlayoutObject = layoutObject();
- return isRootLayer() || layerlayoutObject->isPositioned() || hasTransformRelatedProperty();
- }
-
bool scrollsOverflow() const;
CompositingReasons potentialCompositingReasonsFromStyle() const { return m_potentialCompositingReasonsFromStyle; }
« no previous file with comments | « third_party/WebKit/Source/core/paint/BoxClipper.cpp ('k') | third_party/WebKit/Source/core/paint/PaintLayer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698