third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp - Issue 1490063002: Implement Paint Containment

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

Issue 1490063002: Implement Paint Containment (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rename layer method, add inline tests, address comments, bribe chrishtr, lather, rinse, repeat. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutObject.h ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp ('k') | third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp » ('j') | third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

index a58e6425b55b6bc3fa7010436bde00136b7119da..ddab8c708b8cdd043a996a8e014d120681ee23a2 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingRequirementsUpdater.cpp

@@ -166,7 +166,7 @@ static CompositingReasons subtreeReasonsForCompositing(PaintLayer* layer, bool h

// FIXME: This should move into CompositingReasonFinder::potentialCompositingReasonsFromStyle, but

// theres a poor interaction with LayoutTextControlSingleLine, which sets this hasOverflowClip directly.

- if (layer->layoutObject()->hasClipOrOverflowClip())

+ if (layer->layoutObject()->hasOverflowClipPaintContainmentOrClip())

subtreeReasons |= CompositingReasonClipsCompositingDescendants;

if (layer->layoutObject()->style()->position() == FixedPosition)