Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1490013002: Devirtualize LayoutBlock::firstLineBlock() (Closed)

Created:
5 years ago by Xianzhu
Modified:
5 years ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@FirstLine
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Devirtualize LayoutBlock::firstLineBlock() It's called and meaningful for LayoutBlock only.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -14 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.h View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 2 chunks +1 line, -6 lines 0 comments Download

Depends on Patchset:

Issue 1473363003 Patch 220001

Messages

Total messages: 7 (3 generated)
Xianzhu
5 years ago (2015-12-01 22:51:13 UTC) #2
rune
lgtm
5 years ago (2015-12-01 23:07:15 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1473363003 Patch 220001). Please resolve the dependency and ...
5 years ago (2015-12-02 16:50:09 UTC) #6
mstensho (USE GERRIT)
5 years ago (2015-12-04 13:54:55 UTC) #7 
On 2015/12/02 16:50:09, commit-bot: I haz the power wrote:
> This CL has an open dependency (Issue 1473363003 Patch 220001). Please resolve
> the dependency and try again.

This should be closed, since it got eaten by
https://codereview.chromium.org/1473363003/

Powered by Google App Engine
This is Rietveld 408576698