src/objects.cc - Issue 1490003003: Don't EnsureHasInitialMap on non-constructors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 1490003003: Don't EnsureHasInitialMap on non-constructors (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index f1dd4d7efe96b236d1536c0611969bf3c1fa3de4..21c40aaa59d6854aa5d2de5d2c7609877c5101fb 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -12203,6 +12203,7 @@ bool CanSubclassHaveInobjectProperties(InstanceType instance_type) {

void JSFunction::EnsureHasInitialMap(Handle<JSFunction> function) {

+ DCHECK(function->IsConstructor() || function->shared()->is_generator());

if (function->has_initial_map()) return;

Isolate* isolate = function->GetIsolate();

« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | test/mjsunit/regress/regress-ensure-initial-map.js » ('j') | no next file with comments »