Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 1490003003: Don't EnsureHasInitialMap on non-constructors (Closed)

Created:
5 years ago by Toon Verwaest
Modified:
5 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't EnsureHasInitialMap on non-constructors. non-constructors are not allowed to have initial maps. The optimizing compilers used to add initial maps unconditionally to functions used as right-hand-side in instanceof. BUG= Committed: https://crrev.com/9bee67509c5837d5fb84cddac133e67d289a0cf7 Cr-Commit-Position: refs/heads/master@{#32497}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -14 lines) Patch
M src/compiler/js-typed-lowering.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/crankshaft/hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
A + test/mjsunit/regress/regress-ensure-initial-map.js View 1 chunk +11 lines, -12 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Toon Verwaest
ptal
5 years ago (2015-12-02 08:42:15 UTC) #2
Benedikt Meurer
lgtm
5 years ago (2015-12-02 08:43:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490003003/1
5 years ago (2015-12-02 08:49:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/10885)
5 years ago (2015-12-02 09:02:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1490003003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1490003003/20001
5 years ago (2015-12-02 10:14:46 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 10:39:38 UTC) #13
commit-bot: I haz the power
5 years ago (2015-12-02 10:39:57 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9bee67509c5837d5fb84cddac133e67d289a0cf7
Cr-Commit-Position: refs/heads/master@{#32497}

Powered by Google App Engine
This is Rietveld 408576698