Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 14900003: remove use of WriteAscii for vtune (Closed)

Created:
7 years, 7 months ago by dcarney
Modified:
7 years, 7 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

remove use of WriteAscii for vtune R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14562

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/third_party/vtune/vtune-jit.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
lgtm
7 years, 7 months ago (2013-05-03 07:05:11 UTC) #1
dcarney
Committed patchset #1 manually as r14562 (presubmit successful).
7 years, 7 months ago (2013-05-07 07:23:45 UTC) #2
chunyang.dai
7 years, 7 months ago (2013-05-07 07:39:48 UTC) #3
Message was sent while issue was closed.
hello, Dcarney. 
thanks a lot for your correction.
I just want to upload this fix.

Powered by Google App Engine
This is Rietveld 408576698