Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1489933002: Roll ANGLE 5ac60fc..aca8604 (Closed)

Created:
5 years ago by Geoff Lang
Modified:
5 years ago
Reviewers:
Jamie Madill
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll ANGLE 5ac60fc..aca8604 https://chromium.googlesource.com/angle/angle.git/+log/5ac60fc..aca8604 TBR=jmadill@chromium.org BUG= TEST=bots Committed: https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d Cr-Commit-Position: refs/heads/master@{#362524}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
Geoff Lang
5 years ago (2015-12-01 19:55:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489933002/1
5 years ago (2015-12-01 20:52:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 22:13:36 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cf19fdbc2979c0019fad3c2a33a591ab1790e79d Cr-Commit-Position: refs/heads/master@{#362524}
5 years ago (2015-12-01 22:14:52 UTC) #9
sergeyv
5 years ago (2015-12-02 02:05:25 UTC) #10
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1490133002/ by sergeyv@chromium.org.

The reason for reverting is: Compilation failure at Win x64 GN bot: 
ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe
"E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo
/showIncludes /FC
@obj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj.rsp /c
../../third_party/angle/src/tests/egl_tests/EGLDeviceTest.cpp
/Foobj/third_party/angle/src/tests/angle_end2end_tests/EGLDeviceTest.obj
/Fdobj/third_party/angle/src/tests/angle_end2end_tests_cc.pdb

e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(108)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(113)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(119)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(143)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(162)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(178)
: error C3861: 'eglCreateDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(187)
: error C3861: 'eglQueryDeviceAttribEXT': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(193)
: error C3861: 'eglReleaseDeviceANGLE': identifier not found
e:\b\build\slave\win_x64_gn\build\src\third_party\angle\src\tests\egl_tests\egldevicetest.cpp(207)
: error C3861: 'eglCreateDeviceANGLE': identifier not found


http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/8780
.

Powered by Google App Engine
This is Rietveld 408576698