Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1489923002: Wire up inset of SetUnderlaySurfaceOffsetAndExtendedHitArea (Closed)

Created:
5 years ago by sky
Modified:
5 years ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wire up inset of SetUnderlaySurfaceOffsetAndExtendedHitArea There were a number of bugs in the non-surfaces hit testing code. I've fixed those as part of this, and added tests. BUG=548424 TEST=none R=fsamuel@chromium.org Committed: https://crrev.com/2b4305109457068657d406cf67ebff755a093cf1 Cr-Commit-Position: refs/heads/master@{#362504}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+251 lines, -17 lines) Patch
M components/mus/ws/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/mus/ws/event_dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/mus/ws/event_dispatcher_unittest.cc View 9 chunks +68 lines, -0 lines 0 comments Download
M components/mus/ws/server_window.h View 2 chunks +14 lines, -0 lines 0 comments Download
M components/mus/ws/server_window_surface_manager.h View 2 chunks +3 lines, -0 lines 0 comments Download
M components/mus/ws/server_window_surface_manager.cc View 1 chunk +4 lines, -0 lines 0 comments Download
A components/mus/ws/server_window_surface_manager_test_api.h View 1 chunk +37 lines, -0 lines 0 comments Download
A components/mus/ws/server_window_surface_manager_test_api.cc View 1 chunk +29 lines, -0 lines 0 comments Download
M components/mus/ws/window_finder.h View 1 chunk +8 lines, -7 lines 0 comments Download
M components/mus/ws/window_finder.cc View 2 chunks +26 lines, -8 lines 0 comments Download
A components/mus/ws/window_finder_unittest.cc View 1 chunk +54 lines, -0 lines 0 comments Download
M components/mus/ws/window_tree_unittest.cc View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
sky
5 years ago (2015-12-01 18:51:47 UTC) #1
sky
Note that this disables hit test using surfaces. I'm assuming we'll reenable that once we ...
5 years ago (2015-12-01 18:52:15 UTC) #2
Fady Samuel
lgtm. OK, I'll add this to cc::Surfaces. Thanks
5 years ago (2015-12-01 19:18:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489923002/1
5 years ago (2015-12-01 19:21:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/20658)
5 years ago (2015-12-01 20:14:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489923002/1
5 years ago (2015-12-01 20:26:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 21:31:44 UTC) #10
commit-bot: I haz the power
5 years ago (2015-12-01 21:32:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b4305109457068657d406cf67ebff755a093cf1
Cr-Commit-Position: refs/heads/master@{#362504}

Powered by Google App Engine
This is Rietveld 408576698