content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 1489913003: Handle pointer-events: none in browser process hittesting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 1489913003: Handle pointer-events: none in browser process hittesting. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/site_per_process_browsertest.cc » ('j') | content/renderer/render_frame_proxy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index ef38d30fe02023e6eb3672bc58cb8dc7d416bfe9..82bd02d83ec5b8fc22a1164dad561343230ef500 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -1572,6 +1572,7 @@ uint32_t RenderWidgetHostViewMac::GetSurfaceIdNamespace() {

}

uint32_t RenderWidgetHostViewMac::SurfaceIdNamespaceAtPoint(

+ cc::SurfaceHittestDelegate* delegate,

const gfx::Point& point,

gfx::Point* transformed_point) {

// The surface hittest happens in device pixels, so we need to convert the

@@ -1580,8 +1581,8 @@ uint32_t RenderWidgetHostViewMac::SurfaceIdNamespaceAtPoint(

->GetDisplayNearestWindow(cocoa_view_)

.device_scale_factor();

gfx::Point point_in_pixels = gfx::ConvertPointToPixel(scale_factor, point);

- cc::SurfaceId id = delegated_frame_host_->SurfaceIdAtPoint(point_in_pixels,

- transformed_point);

+ cc::SurfaceId id = delegated_frame_host_->SurfaceIdAtPoint(

+ delegate, point_in_pixels, transformed_point);

*transformed_point = gfx::ConvertPointToDIP(scale_factor, *transformed_point);

// It is possible that the renderer has not yet produced a surface, in which