Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 14899005: Enable extra checks for release builds as well (Closed)

Created:
7 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
7 years, 6 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Enable extra checks for release builds as well R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=14853

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jochen (gone - plz use gerrit)
Danno, what's the status of this? Can we just the checks on by default?
7 years, 7 months ago (2013-05-10 13:18:33 UTC) #1
danno
Let's land this middle to end of next week, after the rest of the bigger ...
7 years, 7 months ago (2013-05-10 14:04:36 UTC) #2
jochen (gone - plz use gerrit)
what about now?
7 years, 7 months ago (2013-05-27 11:23:36 UTC) #3
Jakob Kummerow
I guess now's as good a time as any. LGTM.
7 years, 6 months ago (2013-05-28 09:31:48 UTC) #4
Jakob Kummerow
7 years, 6 months ago (2013-05-28 15:14:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r14853 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698