Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(377)

Side by Side Diff: build/config/android/rules.gni

Issue 1489883002: GN(android): Adds extra_native_libs_even_when_incremental to create_apk() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@native-libs-dir
Patch Set: add comment Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//base/android/linker/config.gni") 5 import("//base/android/linker/config.gni")
6 import("//build/config/android/config.gni") 6 import("//build/config/android/config.gni")
7 import("//build/config/android/internal_rules.gni") 7 import("//build/config/android/internal_rules.gni")
8 import("//build/toolchain/toolchain.gni") 8 import("//build/toolchain/toolchain.gni")
9 import("//third_party/android_platform/config.gni") 9 import("//third_party/android_platform/config.gni")
10 import("//tools/grit/grit_rule.gni") 10 import("//tools/grit/grit_rule.gni")
(...skipping 1610 matching lines...) Expand 10 before | Expand all | Expand 10 after
1621 rebase_path(_native_libs_dir, root_build_dir), 1621 rebase_path(_native_libs_dir, root_build_dir),
1622 "--libraries=@FileArg(${_rebased_build_config}:native:libraries)", 1622 "--libraries=@FileArg(${_rebased_build_config}:native:libraries)",
1623 "--filelistjson=$_rebased_native_libs_json", 1623 "--filelistjson=$_rebased_native_libs_json",
1624 ] 1624 ]
1625 } 1625 }
1626 } 1626 }
1627 1627
1628 _extra_native_libs = [] 1628 _extra_native_libs = []
1629 _extra_native_libs_deps = [] 1629 _extra_native_libs_deps = []
1630 if (_native_libs != []) { 1630 if (_native_libs != []) {
1631 _extra_native_libs_even_when_incremental = []
1632 _extra_native_libs_even_when_incremental_deps = []
1633
1631 if (is_debug) { 1634 if (is_debug) {
1632 _extra_native_libs = [ android_gdbserver ] 1635 _extra_native_libs_even_when_incremental = [ android_gdbserver ]
1633 } 1636 }
1634 1637
1635 if (_use_chromium_linker) { 1638 if (_use_chromium_linker) {
1636 _extra_native_libs = 1639 _extra_native_libs =
1637 [ "$root_shlib_dir/libchromium_android_linker$shlib_extension" ] 1640 [ "$root_shlib_dir/libchromium_android_linker$shlib_extension" ]
1638 _extra_native_libs_deps += 1641 _extra_native_libs_deps +=
1639 [ "//base/android/linker:chromium_android_linker" ] 1642 [ "//base/android/linker:chromium_android_linker" ]
1640 } 1643 }
1641 } 1644 }
1642 1645
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
1684 1687
1685 # This target generates the input file _all_resources_zip_path. 1688 # This target generates the input file _all_resources_zip_path.
1686 deps += _android_manifest_deps + [ 1689 deps += _android_manifest_deps + [
1687 ":$build_config_target", 1690 ":$build_config_target",
1688 ":$process_resources_target", 1691 ":$process_resources_target",
1689 ":$final_dex_target_name", 1692 ":$final_dex_target_name",
1690 ] 1693 ]
1691 1694
1692 if (_native_libs != [] && !_create_abi_split) { 1695 if (_native_libs != [] && !_create_abi_split) {
1693 deps += _native_libs_deps + _extra_native_libs_deps + 1696 deps += _native_libs_deps + _extra_native_libs_deps +
1697 _extra_native_libs_even_when_incremental_deps +
1694 [ _native_libs_file_arg_dep ] 1698 [ _native_libs_file_arg_dep ]
1695 native_libs_filearg = _native_libs_file_arg 1699 native_libs_filearg = _native_libs_file_arg
1696 native_libs = _extra_native_libs 1700 native_libs = _extra_native_libs
1701 native_libs_even_when_incremental =
1702 _extra_native_libs_even_when_incremental
1697 1703
1698 # Placeholders necessary for some older devices. 1704 # Placeholders necessary for some older devices.
1699 # http://crbug.com/395038 1705 # http://crbug.com/395038
1700 forward_variables_from(invoker, [ "native_lib_placeholders" ]) 1706 forward_variables_from(invoker, [ "native_lib_placeholders" ])
1701 } 1707 }
1702 } 1708 }
1703 1709
1704 if (_native_libs != [] && _create_abi_split) { 1710 if (_native_libs != [] && _create_abi_split) {
1705 _manifest_rule = "${_template_name}__split_manifest_abi_${android_app_abi}" 1711 _manifest_rule = "${_template_name}__split_manifest_abi_${android_app_abi}"
1706 generate_split_manifest(_manifest_rule) { 1712 generate_split_manifest(_manifest_rule) {
(...skipping 25 matching lines...) Expand all
1732 # Placeholders necessary for some older devices. 1738 # Placeholders necessary for some older devices.
1733 # http://crbug.com/395038 1739 # http://crbug.com/395038
1734 deps = [] 1740 deps = []
1735 forward_variables_from(invoker, 1741 forward_variables_from(invoker,
1736 [ 1742 [
1737 "deps", 1743 "deps",
1738 "native_lib_placeholders", 1744 "native_lib_placeholders",
1739 "public_deps", 1745 "public_deps",
1740 ]) 1746 ])
1741 1747
1742 incremental_deps = deps + [ ":$_manifest_rule" ] 1748 incremental_deps = deps + _extra_native_libs_even_when_incremental_deps +
1749 [ ":$_manifest_rule" ]
1743 deps = [] 1750 deps = []
1744 deps = incremental_deps + _native_libs_deps + _extra_native_libs_deps + 1751 deps = incremental_deps + _native_libs_deps + _extra_native_libs_deps +
1745 [ _native_libs_file_arg_dep ] 1752 [ _native_libs_file_arg_dep ]
1746 native_libs_filearg = _native_libs_file_arg 1753 native_libs_filearg = _native_libs_file_arg
1747 native_libs = _extra_native_libs 1754 native_libs = _extra_native_libs
1755 native_libs_even_when_incremental =
1756 _extra_native_libs_even_when_incremental
1748 } 1757 }
1749 } 1758 }
1750 1759
1751 _create_incremental_script_rule_name = "${_template_name}__incremental_script" 1760 _create_incremental_script_rule_name = "${_template_name}__incremental_script"
1752 action(_create_incremental_script_rule_name) { 1761 action(_create_incremental_script_rule_name) {
1753 script = "//build/android/incremental_install/create_install_script.py" 1762 script = "//build/android/incremental_install/create_install_script.py"
1754 depfile = "$target_gen_dir/$target_name.d" 1763 depfile = "$target_gen_dir/$target_name.d"
1755 deps = [ 1764 deps = [
1756 _native_libs_file_arg_dep, 1765 _native_libs_file_arg_dep,
1757 ] 1766 ]
(...skipping 18 matching lines...) Expand all
1776 "--dex-file-list=@FileArg($_dex_arg_key)", 1785 "--dex-file-list=@FileArg($_dex_arg_key)",
1777 "--depfile=$_rebased_depfile", 1786 "--depfile=$_rebased_depfile",
1778 ] 1787 ]
1779 if (_proguard_enabled) { 1788 if (_proguard_enabled) {
1780 args += [ "--show-proguard-warning" ] 1789 args += [ "--show-proguard-warning" ]
1781 } 1790 }
1782 if (defined(_native_libs_file_arg)) { 1791 if (defined(_native_libs_file_arg)) {
1783 args += [ "--native-libs=$_native_libs_file_arg" ] 1792 args += [ "--native-libs=$_native_libs_file_arg" ]
1784 } 1793 }
1785 if (_extra_native_libs != []) { 1794 if (_extra_native_libs != []) {
1795 # Don't pass in _extra_native_libs_even_when_incremental, since these are
1796 # end up in the apk and are not side-loaded.
1786 _rebased_extra_native_libs = 1797 _rebased_extra_native_libs =
1787 rebase_path(_extra_native_libs, root_build_dir) 1798 rebase_path(_extra_native_libs, root_build_dir)
1788 args += [ "--native-libs=$_rebased_extra_native_libs" ] 1799 args += [ "--native-libs=$_rebased_extra_native_libs" ]
1789 } 1800 }
1790 if (_create_density_splits) { 1801 if (_create_density_splits) {
1791 args += [ "--split=${_rebased_apk_path_no_ext}-density-*.apk" ] 1802 args += [ "--split=${_rebased_apk_path_no_ext}-density-*.apk" ]
1792 } 1803 }
1793 if (_create_language_splits) { 1804 if (_create_language_splits) {
1794 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ] 1805 args += [ "--split=${_rebased_apk_path_no_ext}-language-*.apk" ]
1795 } 1806 }
(...skipping 407 matching lines...) Expand 10 before | Expand all | Expand 10 after
2203 } 2214 }
2204 2215
2205 android_library(target_name) { 2216 android_library(target_name) {
2206 java_files = [] 2217 java_files = []
2207 srcjar_deps = [ ":${_template_name}__protoc_java" ] 2218 srcjar_deps = [ ":${_template_name}__protoc_java" ]
2208 deps = [ 2219 deps = [
2209 "//third_party/android_protobuf:protobuf_nano_javalib", 2220 "//third_party/android_protobuf:protobuf_nano_javalib",
2210 ] 2221 ]
2211 } 2222 }
2212 } 2223 }
OLDNEW
« no previous file with comments | « build/config/android/internal_rules.gni ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698