Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1489873002: check that SSE2 is available before using __vectorcall (Closed)

Created:
5 years ago by lsalzman1
Modified:
5 years ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

check that SSE2 is available before using __vectorcall BUG=skia:4563 Committed: https://skia.googlesource.com/skia/+/c19247fd03b3498d3d6a6b44421ba75dd49a6ca0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M include/private/SkTLogic.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
lsalzman1
Okay, I made a patch to fix up the SkTLogic.h usage of __vectorcall. Only the ...
5 years ago (2015-12-01 15:06:14 UTC) #2
mtklein
lgtm Just FYI, we don't even pretend to support anything but x86 and x86-64 with ...
5 years ago (2015-12-01 15:08:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489873002/1
5 years ago (2015-12-01 15:08:25 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/c19247fd03b3498d3d6a6b44421ba75dd49a6ca0
5 years ago (2015-12-01 15:21:12 UTC) #7
lsalzman1
5 years ago (2015-12-01 15:22:45 UTC) #8
Message was sent while issue was closed. 
On 2015/12/01 15:08:22, mtklein wrote:
> lgtm
> 
> Just FYI, we don't even pretend to support anything but x86 and x86-64 with
> MSVC.  I'm sure we've got tons and tons of code that assumes MSVC == Windows
==
> x86.

Ah, slight misunderstanding on my part. Re-checked MSDN, and _M_IX86 is defined
for 32 bit, but not 64 bit. Though the logic works in any case, since on x64 it
is always available. Right for the wrong reasons. :)

Powered by Google App Engine
This is Rietveld 408576698