Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1489843003: [WIP: Not for review] Simplify and unify widget/window show logic

Created:
5 years ago by oshima
Modified:
5 years ago
Reviewers:
sadrul
CC:
chromium-reviews, tdanderson+views_chromium.org, sadrul, tfarina, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify and unify widget/window show logic BUG=None

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -53 lines) Patch
M ash/ash.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ash/extended_desktop_unittest.cc View 3 chunks +8 lines, -10 lines 0 comments Download
M ash/wm/lock_layout_manager_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ash/wm/root_window_layout_manager.cc View 2 chunks +8 lines, -6 lines 0 comments Download
A ash/wm/root_window_layout_manager_unittest.cc View 1 chunk +46 lines, -0 lines 0 comments Download
M ash/wm/window_util.cc View 1 chunk +4 lines, -2 lines 0 comments Download
M ash/wm/window_util_unittest.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc View 4 chunks +13 lines, -4 lines 0 comments Download
M ui/aura/test/test_windows.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/window_tracker.h View 3 chunks +9 lines, -1 line 0 comments Download
M ui/aura/window_tracker.cc View 2 chunks +15 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura.cc View 2 chunks +13 lines, -4 lines 1 comment Download
M ui/views/widget/widget.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/widget/widget.cc View 1 2 4 chunks +17 lines, -8 lines 1 comment Download
M ui/views/widget/widget_unittest.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/wm/core/transient_window_manager.cc View 1 chunk +3 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489843003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489843003/20001
5 years ago (2015-12-01 20:52:49 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489843003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489843003/40001
5 years ago (2015-12-01 21:52:10 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489843003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489843003/60001
5 years ago (2015-12-01 22:16:12 UTC) #6
oshima
sadrul@, this is an attempt to make the logic in Widget::ShowWithWindowState clearer. Which approach do ...
5 years ago (2015-12-01 23:00:06 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 23:50:17 UTC) #13 
Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698