Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 1489833002: Revert of [turbofan] Ship TurboFan with new.target references. (Closed)

Created:
5 years ago by Michael Starzinger
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Ship TurboFan with new.target references. (patchset #1 id:1 of https://codereview.chromium.org/1482733002/ ) Reason for revert: Tanks sunspider/date-format-tofte because of the Date constructor being turbofanned. Original issue's description: > [turbofan] Ship TurboFan with new.target references. > > This correctly marks functions containing a new.target reference as > being disabled with Crankshaft, which would have bailed out anyways. > Also note that this will trigger TurboFan for such functions and hence > widens the TurboFan intake valve. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/2ec6fcd1520bb8a09c9924ac5498eb9b437670b0 > Cr-Commit-Position: refs/heads/master@{#32444} TBR=bmeurer@chromium.org,rossberg@chromium.org,hablich@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/3d9a27517c618c7b6600d034e99f7c97adf98d1d Cr-Commit-Position: refs/heads/master@{#32455}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/ast/ast-numbering.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
Michael Starzinger
Created Revert of [turbofan] Ship TurboFan with new.target references.
5 years ago (2015-12-01 12:18:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489833002/1
5 years ago (2015-12-01 12:18:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 12:18:42 UTC) #3
commit-bot: I haz the power
5 years ago (2015-12-01 12:19:11 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d9a27517c618c7b6600d034e99f7c97adf98d1d
Cr-Commit-Position: refs/heads/master@{#32455}

Powered by Google App Engine
This is Rietveld 408576698