Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Issue 148983008: Reduce test code duplication in fast/forms/file (Closed)

Created:
6 years, 10 months ago by sof
Modified:
6 years, 10 months ago
Reviewers:
tkent, keishi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Reduce test code duplication in fast/forms/file Factor out some repeatedly used functions when dragging files onto type=file elements. R= BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -117 lines) Patch
M LayoutTests/fast/forms/file/file-input-change-event.html View 3 chunks +34 lines, -41 lines 0 comments Download
M LayoutTests/fast/forms/file/file-input-empty-validation.html View 2 chunks +1 line, -12 lines 0 comments Download
M LayoutTests/fast/forms/file/file-input-reset.html View 2 chunks +1 line, -8 lines 0 comments Download
M LayoutTests/fast/forms/file/file-input-reset-validation.html View 2 chunks +1 line, -12 lines 0 comments Download
M LayoutTests/fast/forms/file/file-reset-in-change.html View 1 chunk +1 line, -8 lines 0 comments Download
M LayoutTests/fast/forms/file/input-file-value.html View 2 chunks +1 line, -12 lines 0 comments Download
M LayoutTests/fast/forms/file/input-file-write-files.html View 2 chunks +1 line, -12 lines 0 comments Download
M LayoutTests/fast/forms/file/recover-file-input-in-unposted-form.html View 2 chunks +1 line, -12 lines 0 comments Download
A LayoutTests/fast/forms/file/resources/file-drag-common.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sof
Please take a look. As identified in https://codereview.chromium.org/148463008/ , reduce copy-pasting of helper functions.
6 years, 10 months ago (2014-02-08 15:45:07 UTC) #1
tkent
lgtm Thanks!
6 years, 10 months ago (2014-02-10 00:15:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/148983008/1
6 years, 10 months ago (2014-02-10 00:15:42 UTC) #3
commit-bot: I haz the power
6 years, 10 months ago (2014-02-10 02:17:39 UTC) #4
Message was sent while issue was closed.
Change committed as 166782

Powered by Google App Engine
This is Rietveld 408576698