Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148983006: Fix a crash due to uninitialized preference member in ProfileIOData (Closed)

Created:
6 years, 10 months ago by jkarlin
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix a crash due to uninitialized preference member in ProfileIOData when in icognito mode. This variable should always be initialized, not just in incognito mode. BUG=339909 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248873

Patch Set 1 #

Patch Set 2 : Fixes an unitialized pref member in incognito mode. #

Patch Set 3 : Adding a browser test #

Patch Set 4 : Fixed a comment typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -12 lines) Patch
M chrome/browser/prefetch/prefetch_browsertest.cc View 1 2 3 3 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 32 (0 generated)
jkarlin
6 years, 10 months ago (2014-02-04 13:10:07 UTC) #1
jkarlin
Note that I was able to reproduce this crash and verify that this fixes it.
6 years, 10 months ago (2014-02-04 13:18:15 UTC) #2
jkarlin
6 years, 10 months ago (2014-02-04 14:09:20 UTC) #3
jkarlin
tburkard@chromium.org: Please review changes in prefetch/
6 years, 10 months ago (2014-02-04 14:16:13 UTC) #4
cbentzel
LGTM Thanks for adding the test.
6 years, 10 months ago (2014-02-04 14:18:08 UTC) #5
tburkard
lgtm To unsubscribe from this group and stop receiving emails from it, send an email ...
6 years, 10 months ago (2014-02-04 14:19:11 UTC) #6
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 10 months ago (2014-02-04 14:24:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/110001
6 years, 10 months ago (2014-02-04 14:24:41 UTC) #8
jkarlin
jochen: Adding you for profiles/ ownership.
6 years, 10 months ago (2014-02-04 14:27:16 UTC) #9
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 14:29:45 UTC) #10
jochen (gone - plz use gerrit)
lgtm
6 years, 10 months ago (2014-02-04 14:30:29 UTC) #11
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 10 months ago (2014-02-04 14:34:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-04 14:34:12 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 15:19:37 UTC) #14
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=223206
6 years, 10 months ago (2014-02-04 15:19:38 UTC) #15
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 15:19:46 UTC) #16
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 10 months ago (2014-02-04 15:24:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-04 15:25:32 UTC) #18
mmenke
Doesn't look like I'm needed any more, but LGTM.
6 years, 10 months ago (2014-02-04 15:25:40 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 16:28:35 UTC) #20
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120876
6 years, 10 months ago (2014-02-04 16:28:36 UTC) #21
skia-commit-bot
CQ bit was unchecked on CL. Ignoring.
6 years, 10 months ago (2014-02-04 16:28:42 UTC) #22
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 10 months ago (2014-02-04 16:29:54 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-04 16:30:09 UTC) #24
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 17:58:37 UTC) #25
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) url_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_simulator&number=120954
6 years, 10 months ago (2014-02-04 17:58:38 UTC) #26
jkarlin
The CQ bit was checked by jkarlin@chromium.org
6 years, 10 months ago (2014-02-04 18:17:04 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-04 18:20:09 UTC) #28
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, sync_integration_tests, unit_tests ...
6 years, 10 months ago (2014-02-04 20:36:53 UTC) #29
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-04 20:37:45 UTC) #30
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jkarlin@chromium.org/148983006/220001
6 years, 10 months ago (2014-02-05 00:52:07 UTC) #31
commit-bot: I haz the power
6 years, 10 months ago (2014-02-05 06:17:14 UTC) #32
Message was sent while issue was closed. 
Change committed as 248873

Powered by Google App Engine
This is Rietveld 408576698