Issue 1489823003: Check types in '_addFix_createConstructorSuperExplicit'.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1489823003: Check types in '_addFix_createConstructorSuperExplicit'. (Closed)

Created:
5 years ago by scheglov

Modified:
5 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Check types in '_addFix_createConstructorSuperExplicit'. I was not able to reproduce the problem. But this might fix the following exception. Dart analysis server, SDK version 1.13.0, server version 1.12.0, error: Exception from fix contributor: DefaultFixContributor type 'MethodInvocation' is not a subtype of type 'ConstructorDeclaration' in type cast. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/50d9ec3161f59cf614ac64c8448a7eae717075af

Patch Set 1 #

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -0 lines)			Patch
	M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

5 years ago (2015-12-01 21:40:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
50d9ec3161f59cf614ac64c8448a7eae717075af (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages