build/config/android/rules.gni - Issue 1489733002: Run findbugs on instrumentation APKs targets which include Java source files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/android/rules.gni

Issue 1489733002: Run findbugs on instrumentation APKs targets which include Java source files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/android/rules.gni

diff --git a/build/config/android/rules.gni b/build/config/android/rules.gni

index 63d0b184e09f65246500b17044544d1d0079b083..704ca6dbbd57014feb4941ff4290f9f8b891a88b 100644

--- a/build/config/android/rules.gni

+++ b/build/config/android/rules.gni

@@ -1885,7 +1885,10 @@ template("instrumentation_test_apk") {

"//tools/android/forwarder2",

"//tools/android/md5sum",

]

- run_findbugs = false

+ run_findbugs =

+ defined(invoker.run_findbugs) && invoker.run_findbugs &&

+ (defined(invoker.java_files) || defined(invoker.DEPRECATED_java_in_dir))

}

group(target_name) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »