Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 1489733002: Run findbugs on instrumentation APKs targets which include Java source files (Closed)

Created:
5 years ago by pkotwicz
Modified:
5 years ago
Reviewers:
agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run findbugs on instrumentation APKs targets which include Java source files BUG=462737 Committed: https://crrev.com/2999bc5a23ec1931d2fc5511af4e30c485d717a9 Cr-Commit-Position: refs/heads/master@{#362335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/config/android/rules.gni View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
pkotwicz
Andrew, can you please take a look?
5 years ago (2015-12-01 00:46:03 UTC) #2
pkotwicz
I have checked that all of the instrumentation APKs build when run_findbugs is set to ...
5 years ago (2015-12-01 00:47:02 UTC) #3
agrieve
On 2015/12/01 00:47:02, pkotwicz wrote: > I have checked that all of the instrumentation APKs ...
5 years ago (2015-12-01 01:54:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489733002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489733002/1
5 years ago (2015-12-01 02:07:44 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 03:45:27 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-01 03:46:51 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2999bc5a23ec1931d2fc5511af4e30c485d717a9
Cr-Commit-Position: refs/heads/master@{#362335}

Powered by Google App Engine
This is Rietveld 408576698