Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 1489713002: Disable base_unittests:StackTraceTest.OutputToStream on FNL_MUSL (Closed)

Created:
5 years ago by jamesr
Modified:
5 years ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Disable base_unittests:StackTraceTest.OutputToStream on FNL_MUSL This depends on StackTrace::OutputToStream which we don't compile for FNL_MUSL. R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0204e1a3a6679a0e634b66f661e23f424f044152

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M base/debug/stack_trace.h View 1 1 chunk +1 line, -1 line 0 comments Download
M base/debug/stack_trace_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
jamesr
5 years ago (2015-11-30 23:46:57 UTC) #2
kulakowski
lgtm
5 years ago (2015-11-30 23:49:15 UTC) #3
jamesr
5 years ago (2015-11-30 23:56:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0204e1a3a6679a0e634b66f661e23f424f044152 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698