Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1489703002: android: Don't log error when checking weak ref (Closed)

Created:
5 years ago by no sievers
Modified:
5 years ago
Reviewers:
Ted C, Torne
CC:
chromium-reviews, vmpstr+watch_chromium.org, Ted C, mfomitchev
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Don't log error when checking weak ref The point of a weak reference is to be able to try and deref it even when the object is no longer around, so this is not an error. Committed: https://crrev.com/78e532c13851d51105d44ce9224cb32bcc27f87f Cr-Commit-Position: refs/heads/master@{#362485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M base/android/jni_weak_ref.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
no sievers
ptal
5 years ago (2015-11-30 23:17:39 UTC) #3
Ted C
lgtm
5 years ago (2015-11-30 23:25:36 UTC) #6
Torne
lgtm
5 years ago (2015-12-01 12:52:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489703002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489703002/1
5 years ago (2015-12-01 18:28:36 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-01 19:54:58 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-01 19:55:41 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/78e532c13851d51105d44ce9224cb32bcc27f87f
Cr-Commit-Position: refs/heads/master@{#362485}

Powered by Google App Engine
This is Rietveld 408576698