Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 148963013: Omit protocol part in URLs in changelog pages. (Closed)

Created:
6 years, 10 months ago by qyearsley
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/tools/perf.git@master
Visibility:
Public.

Description

Omit protocol part in URLs in changelog pages. Reason for this change: In the past, build.chromium.org was HTTP-only, and so it couldn't be directly put in an iframe on the perf dashboard which uses HTTPS. Annie Sullivan made a page on the perf dashboard, /revision_proxy to get around this. Now, build.chromium.org supports HTTPS, and I wanted to switch the changelog viewer links that the dashboard uses to HTTPS. The purpose of this CL is to make the changelog viewer pages work the same with both HTTP and HTTPS. BUG=

Patch Set 1 #

Patch Set 2 : Omit protocol in js/changelog.js as well. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M dashboard/ui/changelog.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/ui/changelog_blink.html View 1 chunk +2 lines, -2 lines 0 comments Download
M dashboard/ui/changelog_v8.html View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/ui/changelog_webrtc.html View 1 chunk +1 line, -1 line 0 comments Download
M dashboard/ui/js/changelog.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (0 generated)
qyearsley
Hi Henrik, Could you look at this change for in the perf/dashboard/ui/changelog*.html pages? The reason ...
6 years, 10 months ago (2014-01-30 00:27:39 UTC) #1
qyearsley
Note: I'm not completely sure whether it's necessary to also change the URLs for src.chromium.org, ...
6 years, 10 months ago (2014-01-30 00:30:08 UTC) #2
kjellander_chromium
On 2014/01/30 00:30:08, qyearsley wrote: > Note: I'm not completely sure whether it's necessary to ...
6 years, 10 months ago (2014-01-31 08:39:51 UTC) #3
qyearsley
On 2014/01/31 08:39:51, Henrik Kjellander wrote: > On 2014/01/30 00:30:08, qyearsley wrote: > > Note: ...
6 years, 10 months ago (2014-02-04 01:01:00 UTC) #4
kjellander_chromium
On 2014/02/04 01:01:00, qyearsley wrote: > On 2014/01/31 08:39:51, Henrik Kjellander wrote: > > On ...
6 years, 10 months ago (2014-02-04 07:51:43 UTC) #5
qyearsley
On 2014/02/04 07:51:43, Henrik Kjellander wrote: > On 2014/02/04 01:01:00, qyearsley wrote: > > On ...
6 years, 10 months ago (2014-02-04 20:56:34 UTC) #6
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 10 months ago (2014-02-04 20:56:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/148963013/20001
6 years, 10 months ago (2014-02-04 20:58:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/148963013/20001
6 years, 10 months ago (2014-02-04 21:16:43 UTC) #9
commit-bot: I haz the power
Failed to apply patch for perf/dashboard/ui/changelog.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-04 21:16:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/148963013/20001
6 years, 10 months ago (2014-02-04 21:20:28 UTC) #11
commit-bot: I haz the power
Failed to apply patch for perf/dashboard/ui/changelog.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-04 21:20:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/148963013/20001
6 years, 10 months ago (2014-02-04 21:21:47 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 21:21:50 UTC) #14
commit-bot: I haz the power
Failed to apply patch for perf/dashboard/ui/changelog.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-04 21:21:51 UTC) #15
qyearsley
The CQ bit was checked by qyearsley@chromium.org
6 years, 10 months ago (2014-02-04 22:11:33 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/148963013/20001
6 years, 10 months ago (2014-02-04 22:11:45 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-04 22:11:46 UTC) #18
commit-bot: I haz the power
Failed to apply patch for perf/dashboard/ui/changelog.html: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-04 22:11:47 UTC) #19
qyearsley
On 2014/02/04 22:11:47, I haz the power (commit-bot) wrote: > Failed to apply patch for ...
6 years, 10 months ago (2014-02-04 23:37:13 UTC) #20
kjellander_chromium
On 2014/02/04 23:37:13, qyearsley wrote: > On 2014/02/04 22:11:47, I haz the power (commit-bot) wrote: ...
6 years, 10 months ago (2014-02-05 07:01:56 UTC) #21
qyearsley
On 2014/02/05 07:01:56, Henrik Kjellander wrote: > On 2014/02/04 23:37:13, qyearsley wrote: > > On ...
6 years, 10 months ago (2014-02-05 19:18:41 UTC) #22
ghost stip (do not use)
6 years, 9 months ago (2014-03-03 17:52:09 UTC) #23
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/185543008/ by stip@chromium.org.

The reason for reverting is: This just got sync'd on the masters and it's
causing errors for the revision ranges:

Going here:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?u...

leads to a bad request here:
http://build.chromium.org/cgi-bin/svn-log?url=//src.chromium.org/blink//trunk....

Powered by Google App Engine
This is Rietveld 408576698