Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 148963005: Specify -mfpu=neon for neon files (Closed)

Created:
6 years, 10 months ago by Johann
Modified:
6 years, 10 months ago
Reviewers:
Tom Finegan
CC:
chromium-reviews
Visibility:
Public.

Description

Specify -mfpu=neon for neon files Neon files with intrinsics need the extra flag. They also need other -mfpu= flags removed. In order to avoid complexity, don't try to remove the OS==mac condition in the neon intrinsic target. It is not reachable and so safe to ignore. Also don't target the -mfpu removal. It has no effect on x86 builds. TBR=tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247630

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+88 lines, -36 lines) Patch
M generate_gypi.sh View 1 3 chunks +38 lines, -30 lines 0 comments Download
M libvpx.gyp View 1 2 chunks +8 lines, -0 lines 0 comments Download
M libvpx_srcs_arm_neon_cpu_detect.gypi View 1 4 chunks +0 lines, -6 lines 0 comments Download
A libvpx_srcs_arm_neon_cpu_detect_intrinsics.gypi View 1 1 chunk +36 lines, -0 lines 0 comments Download
M libvpx_srcs_x86_64_intrinsics.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download
M libvpx_srcs_x86_intrinsics.gypi View 1 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Johann
6 years, 10 months ago (2014-01-29 05:35:20 UTC) #1
Message was sent while issue was closed.
Committed patchset #2 manually as r247630 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698