Issue 1489603002: Standalone: Use new support in dart:core for decoding data uris.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1489603002: Standalone: Use new support in dart:core for decoding data uris. (Closed)

Created:
5 years ago by rmacnak

Modified:
5 years ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Standalone: Use new support in dart:core for decoding data uris. R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/6fc5018282aba2e5cea0f4bbcf0a9e0126917890

Patch Set 1 #

Total comments: 1

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -21 lines)			Patch
	M	runtime/bin/vmservice/loader.dart	View		1 chunk	+4 lines, -20 lines	0 comments	Download
	M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/1489603002/diff/1/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (left): https://codereview.chromium.org/1489603002/diff/1/runtime/tests/vm/vm.status#oldcode62 runtime/tests/vm/vm.status:62: dart/data_uri_failures_test/base64: RuntimeError, OK As discussed roll these ...

5 years ago (2015-12-01 18:15:15 UTC) #3

rmacnak

5 years ago (2015-12-01 21:46:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
6fc5018282aba2e5cea0f4bbcf0a9e0126917890 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages