Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1538)

Unified Diff: Source/core/platform/graphics/gpu/DrawingBuffer.cpp

Issue 14896002: Always use a separate front texture on Mac OS to work around graphics driver bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/platform/graphics/gpu/DrawingBuffer.cpp
diff --git a/Source/core/platform/graphics/gpu/DrawingBuffer.cpp b/Source/core/platform/graphics/gpu/DrawingBuffer.cpp
index a859f9957199bda1351bb32bd4333b07466c1b0d..a2c3725bfae6d0697911d1d6c6271e50a3d7bb56 100644
--- a/Source/core/platform/graphics/gpu/DrawingBuffer.cpp
+++ b/Source/core/platform/graphics/gpu/DrawingBuffer.cpp
@@ -133,10 +133,20 @@ DrawingBuffer::DrawingBuffer(GraphicsContext3D* context,
{
// Used by browser tests to detect the use of a DrawingBuffer.
TRACE_EVENT_INSTANT0("test_gpu", "DrawingBufferCreation");
+ // Before enabling mailboxes for canvas, make sure the scenarios
+ // from http://crbug.com/234428 do not reproduce!
#if !ENABLE(CANVAS_USES_MAILBOX)
// We need a separate front and back textures if ...
m_separateFrontTexture = m_preserveDrawingBuffer == Preserve // ... we have to preserve contents after compositing, which is done with a copy or ...
|| WebKit::Platform::current()->isThreadedCompositingEnabled(); // ... if we're in threaded mode and need to double buffer.
+
+#if OS(DARWIN)
+ // http://crbug.com/234428 : always use a separate front texture
+ // on Mac OS. Doing this on all GPUs, not just NVIDIA GPUs,
+ // ensures consistent behavior and is much less code.
+ m_separateFrontTexture = true;
+#endif // OS(DARWIN)
+
#endif // !ENABLE(CANVAS_USES_MAILBOX)
initialize(size);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698