Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1489583003: Diagnostic status reporting (#24932). (Closed)

Created:
5 years ago by pquitslund
Modified:
5 years ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Diagnostic status reporting (#24932). Adds a status page for Diagnostic data; notably with timing info which will be handy for getting an informal handle on perf issues (https://github.com/dart-lang/sdk/issues/24932). BUG=24932 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/723dfb2c887058850459bca30a6527aa6fe99876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -25 lines) Patch
M pkg/analysis_server/lib/src/domain_diagnostic.dart View 4 chunks +4 lines, -25 lines 0 comments Download
M pkg/analysis_server/lib/src/status/get_handler.dart View 9 chunks +76 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/utilities/average.dart View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
pquitslund
5 years ago (2015-11-30 20:16:12 UTC) #2
Brian Wilkerson
LGTM
5 years ago (2015-11-30 20:26:21 UTC) #3
pquitslund
5 years ago (2015-11-30 21:02:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
723dfb2c887058850459bca30a6527aa6fe99876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698