Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 1489523003: Add shared libraries to published version of agg-demo (Closed)

Created:
5 years ago by Sam Clegg
Modified:
5 years ago
Reviewers:
bradnelson, bradn
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Add shared libraries to published version of agg-demo The published version of the glibc build was not working for this reason. Committed: https://chromium.googlesource.com/external/naclports/+/44774abd2891e9c9e24811d5614400841273d3e0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M ports/agg-demo/Makefile View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Sam Clegg
5 years ago (2015-11-30 21:09:20 UTC) #2
bradn
lgtm
5 years ago (2015-11-30 21:10:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489523003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489523003/1
5 years ago (2015-12-04 21:52:16 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-04 21:59:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/naclports/+/44774abd2891e9c9e24811...

Powered by Google App Engine
This is Rietveld 408576698