Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: src/hydrogen.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Turn late dead code elimination back on. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/hydrogen.cc
diff --git a/src/hydrogen.cc b/src/hydrogen.cc
index de3254a2721cfc12c599f6a83639fed48928d2bf..2a5433f627c360a4ac1d6dd14493bad3acf6ed76 100644
--- a/src/hydrogen.cc
+++ b/src/hydrogen.cc
@@ -5448,6 +5448,7 @@ void HGraph::MarkLive(HValue *ref, HValue* instr,
if (FLAG_trace_dead_code_elimination) {
HeapStringAllocator allocator;
StringStream stream(&allocator);
+ ALLOW_HANDLE_DEREF(isolate(), "debug mode printing");
Jakob Kummerow 2013/05/16 13:18:57 I don't see any handle being dereferenced?
titzer 2013/05/16 14:28:44 Yeah, it can happen if you try to print an instruc
if (ref != NULL) {
ref->PrintTo(&stream);
} else {

Powered by Google App Engine
This is Rietveld 408576698