Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Side by Side Diff: src/mips/lithium-mips.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Turn late dead code elimination back on. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1677 matching lines...) Expand 10 before | Expand all | Expand 10 after
1688 LOperand* object = UseFixed(instr->value(), a0); 1688 LOperand* object = UseFixed(instr->value(), a0);
1689 LDateField* result = 1689 LDateField* result =
1690 new(zone()) LDateField(object, FixedTemp(a1), instr->index()); 1690 new(zone()) LDateField(object, FixedTemp(a1), instr->index());
1691 return MarkAsCall(DefineFixed(result, v0), instr, CAN_DEOPTIMIZE_EAGERLY); 1691 return MarkAsCall(DefineFixed(result, v0), instr, CAN_DEOPTIMIZE_EAGERLY);
1692 } 1692 }
1693 1693
1694 1694
1695 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1695 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1696 LOperand* string = UseRegister(instr->string()); 1696 LOperand* string = UseRegister(instr->string());
1697 LOperand* index = UseRegister(instr->index()); 1697 LOperand* index = UseRegister(instr->index());
1698 LOperand* value = UseRegister(instr->value()); 1698 LOperand* value = UseTempRegister(instr->value());
1699 LSeqStringSetChar* result = 1699 LSeqStringSetChar* result =
1700 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value); 1700 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1701 return DefineAsRegister(result); 1701 return DefineAsRegister(result);
1702 } 1702 }
1703 1703
1704 1704
1705 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) { 1705 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) {
1706 return NULL; 1706 return NULL;
1707 } 1707 }
1708 1708
(...skipping 770 matching lines...) Expand 10 before | Expand all | Expand 10 after
2479 2479
2480 2480
2481 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2481 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2482 LOperand* object = UseRegister(instr->object()); 2482 LOperand* object = UseRegister(instr->object());
2483 LOperand* index = UseRegister(instr->index()); 2483 LOperand* index = UseRegister(instr->index());
2484 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index)); 2484 return DefineAsRegister(new(zone()) LLoadFieldByIndex(object, index));
2485 } 2485 }
2486 2486
2487 2487
2488 } } // namespace v8::internal 2488 } } // namespace v8::internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698