Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Side by Side Diff: src/ia32/lithium-ia32.cc

Issue 14895019: Fix code gen bug on arm and mips; SeqStringSetChar overwrites a register; Add better default PrintD… (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Turn late dead code elimination back on. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1822 matching lines...) Expand 10 before | Expand all | Expand 10 after
1833 LDateField* result = 1833 LDateField* result =
1834 new(zone()) LDateField(date, FixedTemp(ecx), instr->index()); 1834 new(zone()) LDateField(date, FixedTemp(ecx), instr->index());
1835 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY); 1835 return MarkAsCall(DefineFixed(result, eax), instr, CAN_DEOPTIMIZE_EAGERLY);
1836 } 1836 }
1837 1837
1838 1838
1839 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) { 1839 LInstruction* LChunkBuilder::DoSeqStringSetChar(HSeqStringSetChar* instr) {
1840 LOperand* string = UseRegister(instr->string()); 1840 LOperand* string = UseRegister(instr->string());
1841 LOperand* index = UseRegister(instr->index()); 1841 LOperand* index = UseRegister(instr->index());
1842 ASSERT(ecx.is_byte_register()); 1842 ASSERT(ecx.is_byte_register());
1843 // TODO(titzer): the machine code for this instruction overwrites ecx! fix!
1843 LOperand* value = UseFixed(instr->value(), ecx); 1844 LOperand* value = UseFixed(instr->value(), ecx);
1844 LSeqStringSetChar* result = 1845 LSeqStringSetChar* result =
1845 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value); 1846 new(zone()) LSeqStringSetChar(instr->encoding(), string, index, value);
1846 return DefineSameAsFirst(result); 1847 return DefineSameAsFirst(result);
1847 } 1848 }
1848 1849
1849 1850
1850 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) { 1851 LInstruction* LChunkBuilder::DoNumericConstraint(HNumericConstraint* instr) {
1851 return NULL; 1852 return NULL;
1852 } 1853 }
(...skipping 900 matching lines...) Expand 10 before | Expand all | Expand 10 after
2753 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2754 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2754 LOperand* object = UseRegister(instr->object()); 2755 LOperand* object = UseRegister(instr->object());
2755 LOperand* index = UseTempRegister(instr->index()); 2756 LOperand* index = UseTempRegister(instr->index());
2756 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2757 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2757 } 2758 }
2758 2759
2759 2760
2760 } } // namespace v8::internal 2761 } } // namespace v8::internal
2761 2762
2762 #endif // V8_TARGET_ARCH_IA32 2763 #endif // V8_TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698