Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1261)

Unified Diff: content/browser/mojo/service_registry_android.h

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/mojo/service_registry_android.h
diff --git a/content/browser/mojo/service_registry_android.h b/content/browser/mojo/service_registry_android.h
index eb53d2785faa4bef01075ab76115c6eafc4b2788..d1027fb5bfa5ef45fe137dd643d9050d6c318c90 100644
--- a/content/browser/mojo/service_registry_android.h
+++ b/content/browser/mojo/service_registry_android.h
@@ -26,16 +26,21 @@ class CONTENT_EXPORT ServiceRegistryAndroid {
virtual ~ServiceRegistryAndroid();
// Methods called from Java.
- void AddService(JNIEnv* env,
- jobject j_service_registry,
- jobject j_manager,
- jobject j_factory,
- jstring j_name);
- void RemoveService(JNIEnv* env, jobject j_service_registry, jstring j_name);
- void ConnectToRemoteService(JNIEnv* env,
- jobject j_service_registry,
- jstring j_name,
- jint handle);
+ void AddService(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& j_service_registry,
+ const base::android::JavaParamRef<jobject>& j_manager,
+ const base::android::JavaParamRef<jobject>& j_factory,
+ const base::android::JavaParamRef<jstring>& j_name);
+ void RemoveService(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& j_service_registry,
+ const base::android::JavaParamRef<jstring>& j_name);
+ void ConnectToRemoteService(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& j_service_registry,
+ const base::android::JavaParamRef<jstring>& j_name,
+ jint handle);
const base::android::ScopedJavaGlobalRef<jobject>& GetObj() { return obj_; }

Powered by Google App Engine
This is Rietveld 408576698