Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Unified Diff: content/browser/media/android/media_session.cc

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/media/android/media_session.cc
diff --git a/content/browser/media/android/media_session.cc b/content/browser/media/android/media_session.cc
index 48ceb5468f5417da79e5f39e1a86f60403e0b26b..60360f420e243da124a46a11dda071643d82519e 100644
--- a/content/browser/media/android/media_session.cc
+++ b/content/browser/media/android/media_session.cc
@@ -112,7 +112,9 @@ void MediaSession::RemovePlayers(MediaSessionObserver* observer) {
AbandonSystemAudioFocusIfNeeded();
}
-void MediaSession::OnSuspend(JNIEnv* env, jobject obj, jboolean temporary) {
+void MediaSession::OnSuspend(JNIEnv* env,
+ const JavaParamRef<jobject>& obj,
+ jboolean temporary) {
// TODO(mlamouri): this check makes it so that if a MediaSession is paused and
// then loses audio focus, it will still stay in the Suspended state.
// See https://crbug.com/539998
@@ -129,7 +131,7 @@ void MediaSession::OnSuspend(JNIEnv* env, jobject obj, jboolean temporary) {
UpdateWebContents();
}
-void MediaSession::OnResume(JNIEnv* env, jobject obj) {
+void MediaSession::OnResume(JNIEnv* env, const JavaParamRef<jobject>& obj) {
if (audio_focus_state_ != State::SUSPENDED)
return;

Powered by Google App Engine
This is Rietveld 408576698