Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(811)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/frame_host/navigation_controller_android.h

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/android/date_time_chooser_android.cc ('K') | « content/browser/device_sensors/sensor_manager_android.cc ('k') | content/browser/frame_host/navigation_controller_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/frame_host/navigation_controller_android.h
diff --git a/content/browser/frame_host/navigation_controller_android.h b/content/browser/frame_host/navigation_controller_android.h
index eef468429210ee1cf39ab5f7e43bdf0b6b882da5..ab820dcd704d54b33a1819cbf7e309b58fb36fe6 100644
--- a/content/browser/frame_host/navigation_controller_android.h
+++ b/content/browser/frame_host/navigation_controller_android.h
@@ -33,67 +33,107 @@ class CONTENT_EXPORT NavigationControllerAndroid {
base::android::ScopedJavaLocalRef<jobject> GetJavaObject();
- jboolean CanGoBack(JNIEnv* env, jobject obj);
- jboolean CanGoForward(JNIEnv* env, jobject obj);
- jboolean CanGoToOffset(JNIEnv* env, jobject obj, jint offset);
- void GoBack(JNIEnv* env, jobject obj);
- void GoForward(JNIEnv* env, jobject obj);
- void GoToOffset(JNIEnv* env, jobject obj, jint offset);
- jboolean IsInitialNavigation(JNIEnv* env, jobject obj);
- void LoadIfNecessary(JNIEnv* env, jobject obj);
- void ContinuePendingReload(JNIEnv* env, jobject obj);
- void Reload(JNIEnv* env, jobject obj, jboolean check_for_repost);
- void ReloadIgnoringCache(JNIEnv* env, jobject obj, jboolean check_for_repost);
- void ReloadDisableLoFi(JNIEnv* env, jobject obj, jboolean check_for_repost);
- void RequestRestoreLoad(JNIEnv* env, jobject obj);
- void CancelPendingReload(JNIEnv* env, jobject obj);
- void GoToNavigationIndex(JNIEnv* env, jobject obj, jint index);
- void LoadUrl(JNIEnv* env,
- jobject obj,
- jstring url,
- jint load_url_type,
- jint transition_type,
- jstring j_referrer_url,
- jint referrer_policy,
- jint ua_override_option,
- jstring extra_headers,
- jbyteArray post_data,
- jstring base_url_for_data_url,
- jstring virtual_url_for_data_url,
- jboolean can_load_local_resources,
- jboolean is_renderer_initiated,
- jboolean should_replace_current_entry);
- void ClearSslPreferences(JNIEnv* env, jobject /* obj */);
- bool GetUseDesktopUserAgent(JNIEnv* env, jobject /* obj */);
- void SetUseDesktopUserAgent(JNIEnv* env,
- jobject /* obj */,
- jboolean state,
- jboolean reload_on_state_change);
- base::android::ScopedJavaLocalRef<jobject> GetEntryAtIndex(JNIEnv* env,
- jobject obj,
- int index);
- base::android::ScopedJavaLocalRef<jobject> GetPendingEntry(JNIEnv* env,
- jobject /* obj */);
- int GetNavigationHistory(JNIEnv* env, jobject obj, jobject history);
- void GetDirectedNavigationHistory(JNIEnv* env,
- jobject obj,
- jobject history,
- jboolean is_forward,
- jint max_entries);
+ jboolean CanGoBack(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ jboolean CanGoForward(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ jboolean CanGoToOffset(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint offset);
+ void GoBack(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void GoForward(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
+ void GoToOffset(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint offset);
+ jboolean IsInitialNavigation(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void LoadIfNecessary(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void ContinuePendingReload(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void Reload(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jboolean check_for_repost);
+ void ReloadIgnoringCache(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jboolean check_for_repost);
+ void ReloadDisableLoFi(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jboolean check_for_repost);
+ void RequestRestoreLoad(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void CancelPendingReload(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void GoToNavigationIndex(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint index);
+ void LoadUrl(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& url,
+ jint load_url_type,
+ jint transition_type,
+ const base::android::JavaParamRef<jstring>& j_referrer_url,
+ jint referrer_policy,
+ jint ua_override_option,
+ const base::android::JavaParamRef<jstring>& extra_headers,
+ const base::android::JavaParamRef<jbyteArray>& post_data,
+ const base::android::JavaParamRef<jstring>& base_url_for_data_url,
+ const base::android::JavaParamRef<jstring>& virtual_url_for_data_url,
+ jboolean can_load_local_resources,
+ jboolean is_renderer_initiated,
+ jboolean should_replace_current_entry);
+ void ClearSslPreferences(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& /* obj */);
+ bool GetUseDesktopUserAgent(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& /* obj */);
+ void SetUseDesktopUserAgent(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& /* obj */,
+ jboolean state,
+ jboolean reload_on_state_change);
+ base::android::ScopedJavaLocalRef<jobject> GetEntryAtIndex(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ int index);
+ base::android::ScopedJavaLocalRef<jobject> GetPendingEntry(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& /* obj */);
+ int GetNavigationHistory(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& history);
+ void GetDirectedNavigationHistory(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jobject>& history,
+ jboolean is_forward,
+ jint max_entries);
base::android::ScopedJavaLocalRef<jstring>
- GetOriginalUrlForVisibleNavigationEntry(JNIEnv* env, jobject obj);
- void ClearHistory(JNIEnv* env, jobject obj);
- int GetLastCommittedEntryIndex(JNIEnv* env, jobject obj);
- jboolean RemoveEntryAtIndex(JNIEnv* env, jobject obj, jint index);
- jboolean CanCopyStateOver(JNIEnv* env, jobject obj);
- jboolean CanPruneAllButLastCommitted(JNIEnv* env, jobject obj);
+ GetOriginalUrlForVisibleNavigationEntry(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ void ClearHistory(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ int GetLastCommittedEntryIndex(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ jboolean RemoveEntryAtIndex(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ jint index);
+ jboolean CanCopyStateOver(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
+ jboolean CanPruneAllButLastCommitted(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
void CopyStateFrom(JNIEnv* env,
- jobject obj,
+ const base::android::JavaParamRef<jobject>& obj,
jlong source_native_navigation_controller_android);
void CopyStateFromAndPrune(JNIEnv* env,
- jobject obj,
- jlong source_native_navigation_controller_android,
- jboolean replace_entry);
+ const base::android::JavaParamRef<jobject>& obj,
+ jlong source_native_navigation_controller_android,
+ jboolean replace_entry);
private:
NavigationController* navigation_controller_;
« content/browser/android/date_time_chooser_android.cc ('K') | « content/browser/device_sensors/sensor_manager_android.cc ('k') | content/browser/frame_host/navigation_controller_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698