Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: content/browser/android/tracing_controller_android.h

Issue 1489453003: jni: Pass method parameters as JavaParamRef in content. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/tracing_controller_android.h
diff --git a/content/browser/android/tracing_controller_android.h b/content/browser/android/tracing_controller_android.h
index 58e6b94d36bf2e694a2ef7b06c121233e43e8b80..09f16483b7a099e9f1eefa8965ba711f5a3c7b4f 100644
--- a/content/browser/android/tracing_controller_android.h
+++ b/content/browser/android/tracing_controller_android.h
@@ -17,14 +17,18 @@ namespace content {
class TracingControllerAndroid {
public:
TracingControllerAndroid(JNIEnv* env, jobject obj);
- void Destroy(JNIEnv* env, jobject obj);
+ void Destroy(JNIEnv* env, const base::android::JavaParamRef<jobject>& obj);
bool StartTracing(JNIEnv* env,
- jobject obj,
- jstring categories,
- jstring trace_options);
- void StopTracing(JNIEnv* env, jobject obj, jstring jfilepath);
- bool GetKnownCategoryGroupsAsync(JNIEnv* env, jobject obj);
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& categories,
+ const base::android::JavaParamRef<jstring>& trace_options);
+ void StopTracing(JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj,
+ const base::android::JavaParamRef<jstring>& jfilepath);
+ bool GetKnownCategoryGroupsAsync(
+ JNIEnv* env,
+ const base::android::JavaParamRef<jobject>& obj);
static void GenerateTracingFilePath(base::FilePath* file_path);
private:

Powered by Google App Engine
This is Rietveld 408576698