third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp - Issue 1489433002: Support the essential part of Shadow DOM v1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

Issue 1489433002: Support the essential part of Shadow DOM v1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Revert Internals.* Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

diff --git a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

index bbd8b190102dee95fe5b8dca49eb9a134da2b8bc..e8ca9eca474c6feec375777a83d3b771b13344b0 100644

--- a/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

+++ b/third_party/WebKit/Source/core/dom/LayoutTreeBuilder.cpp

@@ -48,7 +48,7 @@ LayoutTreeBuilderForElement::LayoutTreeBuilderForElement(Element& element, Compu

: LayoutTreeBuilder(element, nullptr)

, m_style(style)

{

- ASSERT(!isActiveInsertionPoint(element));

+ ASSERT(!element.isSlotOrActiveInsertionPoint());

if (element.isFirstLetterPseudoElement()) {

if (LayoutObject* nextLayoutObject = FirstLetterPseudoElement::firstLetterTextLayoutObject(element))

m_layoutObjectParent = nextLayoutObject->parent();