third_party/WebKit/Source/core/dom/Element.cpp - Issue 1489433002: Support the essential part of Shadow DOM v1

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 1489433002: Support the essential part of Shadow DOM v1 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added unit tests. Fixed a minor bug in distribution. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 575b315200c86f5f591b7e574ae3f19c22bd5757..3c553b57c348eb4a5d4f985f16a67fec818d9df3 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -1563,7 +1563,7 @@ void Element::attach(const AttachContext& context)

data->clearComputedStyle();

}

- if (!isActiveInsertionPoint(*this))

+ if (!isSlotOrActiveInsertionPoint())

LayoutTreeBuilderForElement(*this, context.resolvedStyle).createLayoutObjectIfNeeded();

addCallbackSelectors();