Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(976)

Unified Diff: test/mjsunit/harmony/proxies-hash.js

Issue 1489423002: [proxies] Make Object.{freeze,seal} behave correctly for proxies. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add some tests. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/mjsunit/es7/object-observe.js ('k') | test/mjsunit/harmony/proxies-integrity.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/mjsunit/harmony/proxies-hash.js
diff --git a/test/mjsunit/harmony/proxies-hash.js b/test/mjsunit/harmony/proxies-hash.js
index e2e70d45c2bfa3df73e6c03f54c418f3761eea43..830facb28d8ad6df4b6357097c7b7a30a2cf82f0 100644
--- a/test/mjsunit/harmony/proxies-hash.js
+++ b/test/mjsunit/harmony/proxies-hash.js
@@ -32,9 +32,10 @@
function TestWithProxies(test, construct, handler) {
test(construct, handler, function(h) { return new Proxy({}, h) })
- test(construct, handler, function(h) {
- return Proxy.createFunction(h, function() {})
- })
+ // TODO(cbruni): Adapt and enable once we have [[Call]] working.
+ // test(construct, handler, function(h) {
+ // return Proxy.createFunction(h, function() {})
+ // })
}
@@ -70,10 +71,9 @@ function TestSet2(construct, fix, create) {
assertFalse(s.has(p3));
}
-// TODO(neis): Reenable once proxies properly support these operations.
-// TestSet(Set, Object.seal)
-// TestSet(Set, Object.freeze)
-// TestSet(Set, Object.preventExtensions)
+TestSet(Set, Object.seal)
+TestSet(Set, Object.freeze)
+TestSet(Set, Object.preventExtensions)
// Maps and weak maps.
@@ -114,12 +114,10 @@ function TestMap2(construct, fix, create) {
assertSame(undefined, m.get(p2));
}
-// TODO(neis): Reenable once proxies properly support these operations.
-// TestMap(Map, Object.seal)
-// TestMap(Map, Object.freeze)
-// TestMap(Map, Object.preventExtensions)
+TestMap(Map, Object.seal)
+TestMap(Map, Object.freeze)
+TestMap(Map, Object.preventExtensions)
-// TODO(neis): Reenable once proxies properly support these operations.
-// TestMap(WeakMap, Object.seal)
-// TestMap(WeakMap, Object.freeze)
-// TestMap(WeakMap, Object.preventExtensions)
+TestMap(WeakMap, Object.seal)
+TestMap(WeakMap, Object.freeze)
+TestMap(WeakMap, Object.preventExtensions)
« no previous file with comments | « test/mjsunit/es7/object-observe.js ('k') | test/mjsunit/harmony/proxies-integrity.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698