Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issue 1489423002: [proxies] Make Object.{freeze,seal} behave correctly for proxies. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Make Object.{freeze,seal} behave correctly for proxies. - Add JSReceiver::SetIntegrityLevel, with a fast path for regular objects. - Make Object.{freeze,seal} call this via %Object{Freeze,Seal}, thus no longer using broken or deprecated functions from v8natives.js. - Add JSReceiver::OwnPropertyKeys convenience function. - Reenable harmony/proxies-hash.js test. R=rossberg BUG=v8:1543 LOG=N Committed: https://crrev.com/4e2c0dd7a994a84c5ee0dae3736f8ea3640ec55b Cr-Commit-Position: refs/heads/master@{#32651}

Patch Set 1 #

Patch Set 2 : Happily get rid of template. #

Patch Set 3 : Rebase. #

Patch Set 4 : Add some tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -118 lines) Patch
M src/js/v8natives.js View 1 2 1 chunk +2 lines, -42 lines 0 comments Download
M src/objects.h View 1 2 3 chunks +15 lines, -8 lines 0 comments Download
M src/objects.cc View 1 2 3 chunks +66 lines, -19 lines 0 comments Download
M src/runtime/runtime-classes.cc View 1 1 chunk +6 lines, -5 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 1 chunk +10 lines, -16 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/harmony/proxies-hash.js View 1 2 3 chunks +13 lines, -15 lines 0 comments Download
A test/mjsunit/harmony/proxies-integrity.js View 1 2 3 1 chunk +95 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 1 chunk +0 lines, -1 line 0 comments Download
D test/mjsunit/regress/regress-380049.js View 1 chunk +0 lines, -9 lines 0 comments Download
M test/mjsunit/strong/eval-direct.js View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 18 (7 generated)
neis
5 years ago (2015-12-02 14:17:22 UTC) #1
adamk
DBC: Please add more to this CL description before landing, e.g., what were they doing ...
5 years ago (2015-12-02 22:21:18 UTC) #3
neis
PTAL
5 years ago (2015-12-03 16:42:42 UTC) #4
rossberg
lgtm
5 years ago (2015-12-04 13:17:24 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489423002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489423002/40001
5 years ago (2015-12-04 14:27:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years ago (2015-12-04 14:51:48 UTC) #10
neis
On 2015/12/04 14:51:48, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years ago (2015-12-04 16:48:48 UTC) #11
rossberg
lgtm
5 years ago (2015-12-07 10:08:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489423002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489423002/60001
5 years ago (2015-12-07 10:10:31 UTC) #14
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years ago (2015-12-07 11:01:30 UTC) #16
commit-bot: I haz the power
5 years ago (2015-12-07 11:01:40 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4e2c0dd7a994a84c5ee0dae3736f8ea3640ec55b
Cr-Commit-Position: refs/heads/master@{#32651}

Powered by Google App Engine
This is Rietveld 408576698