Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1585)

Issue 1489413007: Subzero: Doxygenify TODO comments. (Closed)

Created:
5 years ago by Jim Stichnoth
Modified:
5 years ago
Reviewers:
Karl, sehr, rkotlerimgtec, John
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: Doxygenify TODO comments. Uses a nasty regexp to turn something like: // ... TODO(stichnot): Fix // this. into: /// ... @todo TODO(stichnot): Fix /// this. so that doxygen can generate the TODO list. Matches "TODO:" and "TODO " and "TODO(...". BUG= none R=rkotlerimgtec@gmail.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=d880f0e2457443277081fb68bb2bbad82177aad1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M Doxyfile View 1 chunk +10 lines, -1 line 0 comments Download
M src/IceTLS.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jim Stichnoth
5 years ago (2015-12-05 00:24:47 UTC) #3
rkotlerimgtec
On 2015/12/05 00:24:47, stichnot wrote: LGTM
5 years ago (2015-12-05 01:34:06 UTC) #4
Jim Stichnoth
5 years ago (2015-12-07 16:37:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d880f0e2457443277081fb68bb2bbad82177aad1 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698