Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Side by Side Diff: build/ios/PRESUBMIT.py

Issue 1489403004: Remove default whitelist for grit on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/ios/OWNERS ('k') | build/ios/grit_whitelist.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file.
4
5 import os
6
7 """Chromium presubmit script for src/tools/ios.
8
9 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
10 for more details on the presubmit API built into depot_tools.
11 """
12
13 WHITELIST_FILE = 'build/ios/grit_whitelist.txt'
14
15 def _CheckWhitelistSorted(input_api, output_api):
16 for path in input_api.LocalPaths():
17 if WHITELIST_FILE == path:
18 lines = open(os.path.join('../..', WHITELIST_FILE)).readlines()
19 i = 0
20 while i < len(lines) - 1 and lines[i] <= lines[i + 1]:
21 i += 1
22 if i < len(lines) - 1:
23 return [output_api.PresubmitError(
24 'The file ' + WHITELIST_FILE + ' must be sorted. ' +
25 'First offending line: #' + str(i + 2))]
26 return []
27
28 def _CommonChecks(input_api, output_api):
29 """Checks common to both upload and commit."""
30 results = []
31 results.extend(_CheckWhitelistSorted(input_api, output_api))
32 return results
33
34 def CheckChangeOnUpload(input_api, output_api):
35 results = []
36 results.extend(_CommonChecks(input_api, output_api))
37 return results
38
39 def CheckChangeOnCommit(input_api, output_api):
40 results = []
41 results.extend(_CommonChecks(input_api, output_api))
42 return results
OLDNEW
« no previous file with comments | « build/ios/OWNERS ('k') | build/ios/grit_whitelist.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698