Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1489403004: Remove default whitelist for grit on iOS. (Closed)

Created:
5 years ago by sdefresne
Modified:
5 years ago
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove default whitelist for grit on iOS. Clear the default value in build/common.gypi and remove overrides in .gyp files. Leave support for whitelisting in grit_action.gypi as it is still used downstream and on android. BUG=548645 Committed: https://crrev.com/32aa7b67dadee74d6e89bd93682354cced97e06c Cr-Commit-Position: refs/heads/master@{#364078}

Patch Set 1 #

Patch Set 2 : Remove build/ios/grit_whitelist.txt #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -682 lines) Patch
M build/common.gypi View 1 2 3 4 1 chunk +0 lines, -3 lines 0 comments Download
M build/ios/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D build/ios/PRESUBMIT.py View 1 chunk +0 lines, -42 lines 0 comments Download
D build/ios/grit_whitelist.txt View 1 2 3 1 chunk +0 lines, -620 lines 0 comments Download
M components/components_resources.gyp View 2 chunks +0 lines, -2 lines 0 comments Download
M components/components_strings.gyp View 3 chunks +0 lines, -3 lines 0 comments Download
M ios/chrome/ios_chrome_resources.gyp View 5 chunks +0 lines, -5 lines 0 comments Download
M ios/chrome/ios_today_extension_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M net/net.gyp View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M ui/resources/ui_resources.gyp View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 32 (14 generated)
sdefresne
Please take a look.
5 years ago (2015-12-03 13:35:10 UTC) #2
blundell
lgtm
5 years ago (2015-12-03 15:01:07 UTC) #5
sdefresne
stuartmorgan: please review the following as OWNERS - build/ios thakis: please review the following as ...
5 years ago (2015-12-03 15:01:40 UTC) #6
sdefresne
stuartmorgan: please review the following as OWNERS - build/ios thakis: please review the following as ...
5 years ago (2015-12-03 15:02:08 UTC) #8
sdefresne
stuartmorgan/thakis/ellyjones: ping
5 years ago (2015-12-04 13:40:52 UTC) #9
stuartmorgan
lgtm
5 years ago (2015-12-04 15:15:12 UTC) #10
sdefresne
thakis/ellyjones: ping
5 years ago (2015-12-07 11:05:37 UTC) #13
Elly Fong-Jones
lgtm
5 years ago (2015-12-07 14:54:38 UTC) #14
sdefresne
thakis: ping
5 years ago (2015-12-08 09:36:19 UTC) #15
Nico
lgtm
5 years ago (2015-12-08 17:36:46 UTC) #16
sdefresne
Thank you!
5 years ago (2015-12-08 17:53:23 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489403004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489403004/60001
5 years ago (2015-12-08 18:00:38 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/89343)
5 years ago (2015-12-08 18:25:32 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489403004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489403004/80001
5 years ago (2015-12-09 09:28:23 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/107600)
5 years ago (2015-12-09 09:57:08 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489403004/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489403004/80001
5 years ago (2015-12-09 16:26:43 UTC) #29
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-09 16:37:57 UTC) #30
commit-bot: I haz the power
5 years ago (2015-12-09 16:38:44 UTC) #32
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/32aa7b67dadee74d6e89bd93682354cced97e06c
Cr-Commit-Position: refs/heads/master@{#364078}

Powered by Google App Engine
This is Rietveld 408576698