Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Unified Diff: src/ia32/builtins-ia32.cc

Issue 1489353004: Remove new.target value from construct stub frames. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@local_turbofan-pass-new-target-9
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/frames.h ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/builtins-ia32.cc
diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc
index b877277726cf4f06e4328c8c3aabd40fd8064387..0ae3775adcc3564021e1a3f42240254808b54813 100644
--- a/src/ia32/builtins-ia32.cc
+++ b/src/ia32/builtins-ia32.cc
@@ -284,10 +284,6 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ SmiUntag(eax);
- // Push new.target onto the construct frame. This is stored just below the
- // receiver on the stack.
- __ push(edx);
-
if (create_implicit_receiver) {
// Push the allocated receiver to the stack. We need two copies
// because we may have to return the original one and the calling
@@ -351,12 +347,11 @@ static void Generate_JSConstructStubHelper(MacroAssembler* masm,
__ mov(eax, Operand(esp, 0));
// Restore the arguments count and leave the construct frame. The
- // arguments
- // count is stored below the reciever and the new.target.
+ // arguments count is stored below the receiver.
__ bind(&exit);
- __ mov(ebx, Operand(esp, 2 * kPointerSize));
+ __ mov(ebx, Operand(esp, 1 * kPointerSize));
} else {
- __ mov(ebx, Operand(esp, kPointerSize));
+ __ mov(ebx, Operand(esp, 0));
}
// Leave construct frame.
« no previous file with comments | « src/frames.h ('k') | src/mips/builtins-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698