Issue 148933005: Add --nologo to reorder-imports.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148933005: Add --nologo to reorder-imports.py. (Closed)

Created:
6 years, 10 months ago by robertshield

Modified:
6 years, 10 months ago

Reviewers:
Cait (Slow)

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add --no-logo to reorder-imports.py. Note, depends on https://codereview.appspot.com/57170049/ landing and Syzygy DEPS rolling to take effect. BUG=335802 TEST=Silent builds again! Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250388

Patch Set 1 #

Patch Set 2 : Use a hyphen. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	build/win/reorder-imports.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

robertshield

The CQ bit was checked by robertshield@chromium.org

6 years, 10 months ago (2014-02-11 01:39:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/148933005/40001

6 years, 10 months ago (2014-02-11 01:40:49 UTC) #5

robertshield

6 years, 10 months ago (2014-02-11 18:38:12 UTC) #8

Message was sent while issue was closed.

On 2014/02/11 18:23:16, scottmg wrote:
> OCD sated, woot!

\o/, but it still needs a DEPS roll which will happen Real Soon Now.

http://urgetokill.ytmnd.com/

Expand Messages | Collapse Messages