A64: Call ProfileEntryHook in JSEntryStub and do not use real aborts in ProfileEntryHook.

A64: Call ProfileEntryHook in JSEntryStub and do not use real aborts in ProfileEntryHook.

TEST=cctest/test-api/SetFunctionEntryHook
R=rodolph.perfetta@arm.com

Committed: https://code.google.com/p/v8/source/detail?r=18928

[ulan, 2014-01-28 17:26:54]

PTAL

https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.cc
File src/a64/code-stubs-a64.cc (right):

https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.c...
src/a64/code-stubs-a64.cc:2744: ProfileEntryHookStub::MaybeCallEntryHook(masm);
On ARM this is called before saving registers, but we cannot do the same here
because jssp is not in sync with csp at the beginning.

https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.c...
src/a64/code-stubs-a64.cc:6458: MacroAssembler::NoUseRealAbortsScope
no_use_real_aborts(masm);
This stub is called in CEntryStub, which sets no_use_real_aborts for its masm,
but here we use a different masm.

https://codereview.chromium.org/148933002/diff/60001/src/a64/code-stubs-a64.c...
src/a64/code-stubs-a64.cc:6933: Handle<Map>
cell_map(masm->isolate()->heap()->cell_map());
ARM uses cell_map, using global_property_cell_map asserts bellow.

[Rodolph Perfetta (ARM), 2014-01-29 11:32:47]

lgtm with nit addressed.

https://codereview.chromium.org/148933002/diff/80001/src/a64/code-stubs-a64.cc
File src/a64/code-stubs-a64.cc (right):

https://codereview.chromium.org/148933002/diff/80001/src/a64/code-stubs-a64.c...
src/a64/code-stubs-a64.cc:6933: Handle<Map>
cell_map(masm->isolate()->heap()->cell_map());
on arm, ia32 and x64 masm->isolate()->factory()->cell_map() is used. Admittedly
it points to the same data but it would be more consistent.

[ulan, 2014-01-29 17:18:05]

https://codereview.chromium.org/148933002/diff/80001/src/a64/code-stubs-a64.cc
File src/a64/code-stubs-a64.cc (right):

https://codereview.chromium.org/148933002/diff/80001/src/a64/code-stubs-a64.c...
src/a64/code-stubs-a64.cc:6933: Handle<Map>
cell_map(masm->isolate()->heap()->cell_map());
On 2014/01/29 11:32:47, Rodolph Perfetta (ARM) wrote:
> on arm, ia32 and x64 masm->isolate()->factory()->cell_map() is used.
Admittedly
> it points to the same data but it would be more consistent. 

Done.

[ulan, 2014-01-29 17:20:22]

Committed patchset #4 manually as r18928 (presubmit successful).