Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/mips64/builtins-mips64.cc

Issue 1489323002: [builtins] Remove some (now) unused code from C++ builtin adaptor. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #if V8_TARGET_ARCH_MIPS64 5 #if V8_TARGET_ARCH_MIPS64
6 6
7 #include "src/codegen.h" 7 #include "src/codegen.h"
8 #include "src/debug/debug.h" 8 #include "src/debug/debug.h"
9 #include "src/deoptimizer.h" 9 #include "src/deoptimizer.h"
10 #include "src/full-codegen/full-codegen.h" 10 #include "src/full-codegen/full-codegen.h"
(...skipping 14 matching lines...) Expand all
25 // (only guaranteed when the called function 25 // (only guaranteed when the called function
26 // is not marked as DontAdaptArguments) 26 // is not marked as DontAdaptArguments)
27 // -- a1 : called function 27 // -- a1 : called function
28 // -- sp[0] : last argument 28 // -- sp[0] : last argument
29 // -- ... 29 // -- ...
30 // -- sp[8 * (argc - 1)] : first argument 30 // -- sp[8 * (argc - 1)] : first argument
31 // -- sp[8 * agrc] : receiver 31 // -- sp[8 * agrc] : receiver
32 // ----------------------------------- 32 // -----------------------------------
33 __ AssertFunction(a1); 33 __ AssertFunction(a1);
34 34
35 // Make sure we operate in the context of the called function (for example
36 // ConstructStubs implemented in C++ will be run in the context of the caller
37 // instead of the callee, due to the way that [[Construct]] is defined for
38 // ordinary functions).
39 // TODO(bmeurer): Can we make this more robust?
40 __ ld(cp, FieldMemOperand(a1, JSFunction::kContextOffset));
41
42 // Insert extra arguments. 35 // Insert extra arguments.
43 int num_extra_args = 0; 36 int num_extra_args = 0;
44 if (extra_args == NEEDS_CALLED_FUNCTION) { 37 if (extra_args == NEEDS_CALLED_FUNCTION) {
45 num_extra_args = 1; 38 num_extra_args = 1;
46 __ push(a1); 39 __ push(a1);
47 } else { 40 } else {
48 DCHECK(extra_args == NO_EXTRA_ARGUMENTS); 41 DCHECK(extra_args == NO_EXTRA_ARGUMENTS);
49 } 42 }
50 43
51 // JumpToExternalReference expects a0 to contain the number of arguments 44 // JumpToExternalReference expects a0 to contain the number of arguments
52 // including the receiver and the extra arguments. But a0 is only valid 45 // including the receiver and the extra arguments.
53 // if the called function is marked as DontAdaptArguments, otherwise we
54 // need to load the argument count from the SharedFunctionInfo.
55 Label argc, done_argc;
56 __ ld(a2, FieldMemOperand(a1, JSFunction::kSharedFunctionInfoOffset));
57 __ lw(a2,
58 FieldMemOperand(a2, SharedFunctionInfo::kFormalParameterCountOffset));
59 __ Branch(&argc, eq, a2,
60 Operand(SharedFunctionInfo::kDontAdaptArgumentsSentinel));
61 __ Daddu(a0, a2, num_extra_args + 1);
62 __ jmp(&done_argc);
63 __ bind(&argc);
64 __ Daddu(a0, a0, num_extra_args + 1); 46 __ Daddu(a0, a0, num_extra_args + 1);
65 __ bind(&done_argc);
66 47
67 __ JumpToExternalReference(ExternalReference(id, masm->isolate())); 48 __ JumpToExternalReference(ExternalReference(id, masm->isolate()));
68 } 49 }
69 50
70 51
71 // Load the built-in InternalArray function from the current context. 52 // Load the built-in InternalArray function from the current context.
72 static void GenerateLoadInternalArrayFunction(MacroAssembler* masm, 53 static void GenerateLoadInternalArrayFunction(MacroAssembler* masm,
73 Register result) { 54 Register result) {
74 // Load the InternalArray function from the native context. 55 // Load the InternalArray function from the native context.
75 __ LoadNativeContextSlot(Context::INTERNAL_ARRAY_FUNCTION_INDEX, result); 56 __ LoadNativeContextSlot(Context::INTERNAL_ARRAY_FUNCTION_INDEX, result);
(...skipping 1902 matching lines...) Expand 10 before | Expand all | Expand 10 after
1978 } 1959 }
1979 } 1960 }
1980 1961
1981 1962
1982 #undef __ 1963 #undef __
1983 1964
1984 } // namespace internal 1965 } // namespace internal
1985 } // namespace v8 1966 } // namespace v8
1986 1967
1987 #endif // V8_TARGET_ARCH_MIPS64 1968 #endif // V8_TARGET_ARCH_MIPS64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698