Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1489323002: [builtins] Remove some (now) unused code from C++ builtin adaptor. (Closed)

Created:
5 years ago by Benedikt Meurer
Modified:
5 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove some (now) unused code from C++ builtin adaptor. Sanitize ConstructStub handling and add a test case to ensure that the Symbol constructor is using the correct context. R=jarin@chromium.org BUG=v8:4413 LOG=n Committed: https://crrev.com/f618401a8ef2e45d727db14a93bb344997ade527 Cr-Commit-Position: refs/heads/master@{#32491}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address feedback. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -176 lines) Patch
M src/arm/builtins-arm.cc View 1 3 chunks +1 line, -18 lines 0 comments Download
M src/arm64/builtins-arm64.cc View 1 3 chunks +1 line, -17 lines 0 comments Download
M src/builtins.h View 1 chunk +1 line, -1 line 0 comments Download
M src/builtins.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 1 3 chunks +1 line, -23 lines 0 comments Download
M src/mips/builtins-mips.cc View 1 3 chunks +1 line, -23 lines 0 comments Download
M src/mips64/builtins-mips64.cc View 1 3 chunks +1 line, -22 lines 0 comments Download
M src/ppc/builtins-ppc.cc View 1 3 chunks +1 line, -27 lines 0 comments Download
M src/x64/builtins-x64.cc View 1 3 chunks +1 line, -22 lines 0 comments Download
M src/x87/builtins-x87.cc View 1 3 chunks +1 line, -23 lines 0 comments Download
M test/mjsunit/es6/symbols.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Benedikt Meurer
5 years ago (2015-12-02 06:31:30 UTC) #1
Benedikt Meurer
Hey Jaro, Here's a fixup after the Call protocol sanitizing. Please take a look. Thanks, ...
5 years ago (2015-12-02 06:32:18 UTC) #2
Jarin
lgtm https://codereview.chromium.org/1489323002/diff/1/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1489323002/diff/1/src/arm64/builtins-arm64.cc#newcode42 src/arm64/builtins-arm64.cc:42: // is not marked as DontAdaptArguments) Should not ...
5 years ago (2015-12-02 07:00:37 UTC) #3
Benedikt Meurer
https://codereview.chromium.org/1489323002/diff/1/src/arm64/builtins-arm64.cc File src/arm64/builtins-arm64.cc (right): https://codereview.chromium.org/1489323002/diff/1/src/arm64/builtins-arm64.cc#newcode42 src/arm64/builtins-arm64.cc:42: // is not marked as DontAdaptArguments) On 2015/12/02 07:00:36, ...
5 years ago (2015-12-02 07:02:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1489323002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1489323002/20001
5 years ago (2015-12-02 07:03:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-02 07:31:54 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-02 07:32:19 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f618401a8ef2e45d727db14a93bb344997ade527
Cr-Commit-Position: refs/heads/master@{#32491}

Powered by Google App Engine
This is Rietveld 408576698