handler/handler_main.cc - Issue 1489293004: win: Fix some warnings reported by /analyze

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: handler/handler_main.cc

Issue 1489293004: win: Fix some warnings reported by /analyze (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: . Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: handler/handler_main.cc

diff --git a/handler/handler_main.cc b/handler/handler_main.cc

index 923d2b7ca770326849b7b58db5cd1d8dcd251283..16855fa82642e9ef92605ec600e35d4195a6cdb5 100644

--- a/handler/handler_main.cc

+++ b/handler/handler_main.cc

@@ -339,7 +339,6 @@ int HandlerMain(int argc, char* argv[]) {

#elif defined(OS_WIN)

ExceptionHandlerServer exception_handler_server(!options.pipe_name.empty());

- std::string pipe_name;

if (!options.pipe_name.empty()) {

exception_handler_server.SetPipeName(base::UTF8ToUTF16(options.pipe_name));

} else if (options.handshake_handle != INVALID_HANDLE_VALUE) {

« no previous file with comments | « no previous file | util/win/process_info.cc » ('j') | no next file with comments »