util/win/process_info.cc - Issue 1489293004: win: Fix some warnings reported by /analyze

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: util/win/process_info.cc

Issue 1489293004: win: Fix some warnings reported by /analyze (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: util/win/process_info.cc

diff --git a/util/win/process_info.cc b/util/win/process_info.cc

index 2ac3a98bfacbe937f5bb60edda1e93bbb74c51be..ae76ba341f79fc83d53a0c0a2f11d93d03cfe408 100644

--- a/util/win/process_info.cc

+++ b/util/win/process_info.cc

@@ -224,7 +224,7 @@ bool ReadProcessData(HANDLE process,

ProcessInfo* process_info) {

typename Traits::Pointer peb_address;

if (!AssignIfInRange(&peb_address, peb_address_vmaddr)) {

- LOG(ERROR) << base::StringPrintf("peb address 0x%x out of range",

+ LOG(ERROR) << base::StringPrintf("peb address 0xllx out of range",

Mark Mentovai 2015/12/02 21:46:33 You lost the %.

scottmg 2015/12/02 21:51:56 That would have been a poor "improvement"! Thanks.

peb_address_vmaddr);

return false;

}

« no previous file with comments | « handler/handler_main.cc ('k') | no next file » | no next file with comments »